Reorganize blech_process.log to group by status#731
Open
abuzarmahmood wants to merge 4 commits into
Open
Conversation
Restructure the log file so top-level keys are 'complete' and 'attempted' instead of electrode numbers. Electrodes are now grouped under their respective status, making it easier to see processing state at a glance. Fixes katzlabbrandeis#729 Co-authored-by: Ona <no-reply@ona.com>
Member
Author
Solution OverviewThe log file structure has been reorganized from a flat electrode-keyed format to a status-keyed format. Before (flat structure){
"0": {"start_time": "...", "status": "complete", "end_time": "..."},
"16": {"start_time": "...", "status": "attempted"}
}After (status-grouped structure){
"complete": {
"0": {"start_time": "...", "end_time": "..."}
},
"attempted": {
"16": {"start_time": "..."}
}
}Implementation details
This makes it easier to see at a glance which electrodes completed successfully vs which are still in progress or failed. |
Read incomplete electrodes from 'attempted' key instead of iterating all entries and checking status field. Co-authored-by: Ona <no-reply@ona.com>
Member
Author
|
Added update to The completion check now reads from |
Update pipeline_graph_check.write_to_log to remove the script from 'attempted' when adding it to 'completed', keeping the log structure consistent. Co-authored-by: Ona <no-reply@ona.com>
Member
Author
|
Added update to
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Restructures
blech_process.logso the top-level keys arecompleteandattemptedinstead of electrode numbers. Also updates related log handling in other files.Changes
completeorattempted)attemptedattemptedtocompletecompletebefore adding toattemptedpipeline_graph_check.write_to_logto remove script fromattemptedwhen marking ascompletedNew log structure
{ "complete": { "0": {"start_time": "...", "end_time": "..."}, "1": {"start_time": "...", "end_time": "..."} }, "attempted": { "16": {"start_time": "..."}, "17": {"start_time": "..."} } }Fixes #729