Feat/dockerize UI#44
Merged
Merged
Conversation
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The final image size is 93.89 MB, kept lean via a multi-stage build (Node for building, Nginx Alpine for serving). The container exposes port 80 internally, mapped to port 3000 on the host and so the ui is accessible at
http://localhost:3000.Build and run the image from the root directory by executing
docker compose up --build.After reviewing
ui/app/page.tsx, the UI does not make any HTTP requests to the API. It communicates with the backend exclusively via Wails bindings, and automatically falls back to hardcoded mock data inui/lib/data.tswhen running outside of the Wails runtime. And therefore, this is why I think a mock API service indocker-compose.ymlnot needed.closes #20