Warn when a pause hook blocks the ecs:* lifecycle stage wait - #1070
Merged
Conversation
When waiting for a lifecycle stage with --wait-until ecs:<stage>, a pause lifecycle hook awaiting action blocks the deployment, which looks like a hang. Log a warning once per hook with a hint to run `ecspresso continue`. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Signed-off-by: fujiwara <fujiwara.shunichiro@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Port of #1069 to pre-v3.
What
While
deploy --wait-until ecs:<stage>is polling, if a pause lifecycle hook is awaiting action, log a warning (once per hook) with the hook ID, the current stage, the target stage, and a hint to runecspresso continue. The pause detection is extracted intopausedHookIDs, shared withdeploymentPaused(the--wait-until=pausedpath).Why
A pause hook configured at a stage earlier than the target blocks the deployment until it is continued, so the wait looks like a hang. The warning tells the operator what is happening and what to do at the moment it matters, instead of speculatively warning at deploy start (pausing is an intentional configuration).
🤖 Generated with Claude Code