chore(biome): .claude の除外をリポジトリ直下だけにする - #1122
Merged
Merged
Conversation
`!**/.claude` は worktree の絶対パスに含まれる `.claude/worktrees/` にも マッチし、`.claude/worktrees/` 配下の worktree で `biome check .` が 0 ファイルになっていた。ファイルを明示する post-edit hook は動くため 気付きにくく、`pnpm lint` だけが worktree 内で通らない状態だった。 config ルート相対の `!.claude` に変えて、リポジトリ直下の `.claude/` だけを除外する。 Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01AYsHuZj1hWRdK1hieBG5YU
Contributor
Coverage Report for server
File CoverageNo changed files found. |
Contributor
Coverage Report for web
File CoverageNo changed files found. |
Contributor
Coverage Report for shared
File CoverageNo changed files found. |
Contributor
Coverage Report for widget
File CoverageNo changed files found. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
biome.jsonのfiles.includesにある!**/.claudeを!.claudeに変更する主な変更内容
!**/.claudeは絶対パスの祖先ディレクトリにもマッチするため、.claude/worktrees/配下に作った git worktree ではbiome check .（pnpm lintの先頭）がディレクトリ走査をそこで打ち切り、「Checked 0 files / No files were processed」で失敗していた。ファイルを明示して渡すpost-edit-lint.shは動くため気付きにくく、pnpm lintだけが worktree 内で通らない状態だった。config ルート相対の
!.claudeに変えると、除外されるのはリポジトリ直下の.claude/だけになる。確認したこと:
biome check .の処理数は変更前後とも 731 ファイルで変わらないbiome check .claudeは変更後も 0 ファイル（除外は維持）.claude/worktrees/配下の既存 worktree でbiome check .が 0 → 719 ファイルになる.claudeという名前のディレクトリはルート以外に無いTest plan
biome check .が通る.claude/worktrees/配下の worktree でpnpm lintが通る