Repository navigation
Add a bounded local pre-shell environment option - #1
Draft
kazooooo-ma wants to merge 1 commit into
Draft
kazooooo-ma wants to merge 1 commit into
kazooooo-ma wants to merge 1 commit into
Conversation
Forward explicit startup sync policy through terminal.create.env before shell startup. Refuse unrelated environment keys and unverified execution hosts, and bind creation to the verified worktree id.
7 of 9 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ELI5
Let a caller disable automatic settings synchronization before a new terminal's shell starts.
What Changed
terminal create --env-jsonfor the explicitSETTINGS_AUTO_SYNCstring values0and1terminal.create.envfield, binding creation to the verified worktree ID--shellcapability checks and the unchanged payload and RPC sequence when the new flag is absentWhy
A command-time export runs after shell startup hooks. The existing spawn-environment field applies the policy early enough without adding another launch path.
Linked Issue
N/A: fork-local change.
Visual Proof
N/A: command-line and startup-environment behavior only.
Testing
Added 24 parser cases. An isolated Node 24 adapter and inert RPC fixtures passed 43 parser, handler, host-boundary, shell-compatibility and specification checks. Independent source review approved this exact patch.
Native Vitest, typecheck, lint, application build, and live terminal verification remain pending.
AI Disclosure
Implementation was assisted by OpenAI Codex.
Review
Source-only proposal. Apply and verify the CLI before dependent callers enable the new option.
Agent skill upstream boundary
Notes
The comparison base is pinned to upstream commit
3284b4c70c901402831bb4ccc5576ea083d2e5aeso this PR contains only the five changed files. The fork's main branch is unchanged.Explicit environment use is restricted to a verified local worktree. Existing remote behavior without the flag is preserved.
Checklist