Add “infinite” mode#25
Open
tobinibot wants to merge 2 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I (and [many](http://stackoverflow.com/questions/15803937/restart-countdown-timer-when-expired other) others) would like timers that automatically reset themselves after expiry. An example use case would just be someone (like me) who wants to update a status page every 30 seconds. Sure, I could just use setInterval, but I like to show a little countdown that displays how long until the page auto-refreshes itself. I could also just restart the timer myself (outside the plugin), but I’d prefer for this functionality to be built in.
I added an
infiniteoption that does just that. If you setinfinitetotrue_and_ you have anuntiloption that is a relative time, then the timer restarts after it expires. If you have anuntilthat is a date, infinite mode doesn’t really make sense, so nothing happens in that case.Disclaimer - this code works awesome for me, but I have not tested it against all the possible configurations and uses.