This repository was archived by the owner on Jun 22, 2023. It is now read-only.
Revert KB default scaffolding#9
Merged
varshaprasad96 merged 2 commits intokcp-dev:mainfrom Nov 10, 2022
Merged
Conversation
Contributor
|
/hold |
Contributor
|
Just a note here. This is PR to add a few scaffolding pieces that were removed early on but now they will be needed to construct some build/install targets in Makefile to facilitate the work on #5 PR. |
dinhxuanvu
added
the
do-not-merge
dinhxuanvu
reviewed
Nov 10, 2022
varshaprasad96
force-pushed
the
revert/kb-scaffolding
branch
from
ae26068 to
a701424
Compare
dinhxuanvu
reviewed
Nov 10, 2022
varshaprasad96
force-pushed
the
revert/kb-scaffolding
branch
from
a164aba to
e1b9a89
Compare
varshaprasad96
removed
the
do-not-merge
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A bunch of files in config/ folder were removed in the initial catalog spec PR. These files are a part of Kubebuilder's default scaffolding, for making the Makefile targets (like
make manifestsandmake kustomizework). This PR adds those default files back, and bumps the KCP and other k8s dependencies to the latest version.