Repository navigation
chore(deps): bump filament-kmp to 0.7.12 - #767
Merged
Merged
Conversation
Fixes the home screen showing swapped or missing glyphs and icons on Windows after its 3D widgets are rebuilt (closing tabs back to it): releasing a shared Filament engine left the window's EGL binding broken (kdroidFilter/filament-kmp#20). Signed-off-by: Elie G. <elyahou.hadass@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Bumps filament-kmp from 0.7.10 to 0.7.12.
0.7.12 fixes the home screen showing swapped or missing glyphs and icons on Windows (chevrons drawn as folders, gears, ×, text gone) right after its 3D widgets are rebuilt, e.g. when closing tabs back to it. Releasing a shared Filament engine destroyed its GL share context while the window's context was current, and ANGLE then left the window's EGL binding broken; the next shared texture's creation left the window's frame with no context, losing Skia's texture uploads until the GPU cache was purged (minimize/restore). Fix: kdroidFilter/filament-kmp#20.
Not related to partial redraw: it reproduces with
-Dnucleus.tao.partialRedraw=false.Testing
filament-c.dll.:SeforimApp:compileKotlinJvmand:earthwidget:compileKotlinJvmpass with 0.7.12; everydev.nucleusframework.filament:*artifact resolves to 0.7.12.A defensive re-bind on the Nucleus side is in NucleusFramework/Nucleus#916.