Repository navigation
Conversation
The notes pane editor now has two modes. In edit mode it is the raw Markdown text field (as before: debounced auto-save, flush on blur). In view mode the note is rendered with the app's existing Jewel Markdown renderer (AccentMarkdown: Hebrew serif, accent links, justified RTL paragraphs). Saved notes open in view mode; drafts and blank notes open in edit mode. A hover-revealed footer button (with a tooltip) toggles between the modes, a double-click on the rendered note starts editing, and blurring the field returns to view. Places that show a note as a one-line title (Notes screen, notes popup, home Notes widget, macOS menu bar) now flatten the Markdown to plain text via the new markdownToPlainText(), so syntax like "**" or "##" never leaks into titles. No new dependency: rendering reuses jewel-markdown, which the app already ships. Signed-off-by: Chagai Yisroel Wild <wildhagai@puzzlesoft.co.il> Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
User notes now support Markdown, with an edit mode and a view mode.
NotesPanel.kt): the editor has two modes.AccentMarkdown(Jewel Markdown: bold, italic, headings, lists, links, inline code, quotes). It uses the Hebrew serif font and justified right-to-left paragraphs.markdownToPlainText(), so**,##, link syntax and so on never show up in titles.note_edit,note_preview.Dependencies
None added. Rendering reuses
jewel-markdown, which the app already ships.Testing
./gradlew :SeforimApp:jvmTest --tests "…MarkdownTextTest": 13/13 pass (headings, emphasis, snake_case kept as is, inline code, links/images, lists/task boxes, quotes, code fences/rules, escapes, Hebrew)../gradlew :SeforimApp:ktlintCheck: clean.:SeforimApp:compileKotlinJvm: OK.Not yet verified
AppNativeMenuBar.ktis the macOS menu bar, and this was developed on Windows. The change there is a small call tomarkdownToPlainText(), but it was only reviewed by eye, not exercised on macOS.🤖 Generated with Claude Code