Repository navigation
Conversation
- Rav Chaim Naeh as an amma opinion (etzba 2 cm, amma 48 cm), cited from Kitzur Shulchan Aruch Yalkut Yosef, OC 630:4. - A length/volume switch. Volumes: revi'is, log, kav, se'ah, eifah, kor (Rambam Eruvin 1:13, Arachin 4:4). Each opinion's revi'is is its etzba cubed times 2x2x2.7 (Pesachim 109a): Naeh 86.4 ml, Chazon Ish ~152 ml. The Igros Moshe is left out of volumes, since R' Moshe's revi'is is not derived from his amma. - Metric units in the picker: mm, cm, m, km and ml, liter. Between Torah and metric units the result is a range over the opinions shown. - An opinion added after the user saved a choice is shown until unticked. - Fix an init cycle between MeasuresWidget and MeasuresSettings. Signed-off-by: Chagai Yisroel Wild <wildhagai@puzzlesoft.co.il> Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
offeredsetting.MeasuresWidgetandMeasuresSettings, where each needed the other before it existed. The loop predates this PR; the new tests exposed it.Sources (each line index checked against the library text)
All figures are cited.
Please check: the Yalkut Yosef citation uses the book title as it appears in the library file (
קיצור שע ילקוט יוסף החדש - אורח חיים, with no quote mark). It's worth opening that citation once in the app to confirm the database stores the title the same way.Tests
MeasuresTest: 12/12 pass. They cover volume conversions, revi'it per opinion, metric conversions, number formatting, the setting for newly added opinions, and card height.ktlintCheckpasses.🤖 Generated with Claude Code