Repository navigation
fix(bookcontent): keep the book title visible on open - #776
Merged
Merged
Conversation
…ed line into view The bring-into-view effect read listState.layoutInfo as soon as the pages had loaded, a frame before the list laid them out. On that stale layout (the loading item alone) the first TOC line looked off screen, so the list jumped to it and the book's title above it was hidden on open. Wait for a layout that holds the line's index first.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
On open, a book sometimes showed its first TOC line at the top, with the book's title (above it) scrolled out of view.
The bring-into-view effect read
listState.layoutInfoas soon as the pages had loaded, one frame before theLazyColumnlaid them out. On that stale layout (the loading item alone,total=1), the selected line looked off screen, so the effect calledscrollToItem(index)and jumped past the lines above it, the title among them.Trace from a failing run:
Fix
Before judging visibility, wait (up to 1.5 s) for a layout that holds the line's index:
Verification
ZAYIT_E2E_SCENARIO, isolated user DB) with traces showing the stale layout.ktlintCheckanddetektpass.