Open
Conversation
Notes are displayed on playboard in small letters if the box is otherwise blank. Needed to add to Box.java an across and down clue number and position calculated during setBoxes. Additionally, the PlayboardRenderer draw functions now have two arguments: displayScratchAcross and displayScratchDown to indicate whether to add notes to the board. The drawBox function fetches and renders the scratch notes if required. Two options are needed because it is not pleasing to show the scratch on the notes page for the clue being edited (but you do want to see the scratch for other clues). An option has been added to preferences to enable/disable this behaviour. Default off.
Author
|
Inspired by issue #124 i've added a preference to display the scratch part of the notes page on the playboard in smaller letters. As per the commit message, this turned out to be more awkward than anticipated and needed a lot of new code, which may or may not be the best approach. Comments welcome. Feel free to accept without this commit (f31bee9). edit: just spotted a small bug, working on it now. |
Author
|
Bug fixed -- this affects all versions, so commit 7fb08c9 should be applied with anything from this PR. Apologies for the increasingly complex PR! |
Author
|
Some screenshots :)
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added a notes page activity where notes, partial solutions, and anagrams can be experimented with. I find this useful for cryptic crosswords.
This includes the addition of a NotesActivity class as well as a BoardEditText widget (akin to TextEdit) to edit text in crossword style. I have also added an options menu to the clues list activity, though the only option is to get to the notes page.
Notes are stored in the same file as the user's crossword answers in a section marked with ANTS and DNTS (across/down notes). This is similar to GEXT and if it is not present it is assumed empty. (Ie existing files with previous versions of Shortyz should work perfectly well.)
A smaller technical change is to the PlayboardRenderer class's drawBox method to take the selected square position (used by BoardEditText).
Future work might be to refactor NotesActivity and ClueListActivity to remove a lot of copy-pasted code to do with keyboard handling.
edit: i made an issue earlier asking if i should do this, but i had time today anyway.
editedit: this version still needs longer term testing. Basic features work fine.