Skip to content

A couple of fixes from production usage - #17

Merged
keithpotz merged 7 commits into
keithpotz:mainfrom
dimhotepus:cleanup-src
Nov 10, 2026
Merged

keithpotz merged 7 commits into
keithpotz:mainfrom
dimhotepus:cleanup-src

Conversation

@dimhotepus

@dimhotepus dimhotepus commented Sep 29, 2026 •

Copy link
Copy Markdown
Contributor

Description

A lot of changes from production usage.

Type of Change

  • Bug fix
  • New feature
  • Enhancement

How to Test

Default test suite.

Checklist

  • I have read the contributing guidelines
  • I have tested the changes
  • My code follows the code style of this project
  • I have added tests to cover my changes
  • All new and existing tests passed

@keithpotz keithpotz left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See my comment on line 93 in CrashCatch.hpp. Let me know what you think and we can go from there.

Comment thread include/CrashCatch.hpp Resolved
@0xsmft

0xsmft commented Nov 9, 2026

Copy link
Copy Markdown
Contributor

I can confirm that these changes work fine on macOS 27 (on AArch64).

@keithpotz keithpotz left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All looks good and passed. Thank you for your contribution!

@keithpotz
keithpotz merged commit f97c0f0 into keithpotz:main Nov 10, 2026
2 of 4 checks passed
keithpotz added a commit that referenced this pull request Nov 10, 2026
Follow-up to PR #17 plus v1.6.0 release docs.

Fixes:
- shutdown() is now safe to call more than once or without
  initialize(); it no longer overwrites the app's own crash handlers
- A second initialize() now only updates the config; before, it made
  shutdown() unable to restore the app's original handler
- Windows: .dmp file is closed right after it's written, so it's no
  longer locked while the crash dialog is open
- Windows: user32.lib is linked automatically (needed by MessageBoxW)
- macOS: demangle() no longer throws or hangs on malformed backtrace
  lines inside the crash handler
- macOS: atos command fixed to "atos -p <pid>" (was missing a space)

C API:
- crashcatch_shutdown(void) is now declared in the public header so
  C callers can use it
- crashcatch_version() now returns "1.6.0"

Docs:
- New docs/macos.md page, added to the mkdoc
- docs/index.md: macOS now listed as supported (platform table,
  features, requirements, roadmap)
- CHANGELOG.md: new [1.6.0] entry
- RELEASE.md: rewritten for v1.6.0
- README.md: fixed CrashCath::shutdown() typ
  now says v1.6.0
- mkdocs.yml: site description now includes macOS
@dimhotepus
dimhotepus deleted the cleanup-src branch November 16, 2026 02:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants