Repository navigation
A couple of fixes from production usage - #17
Merged
Merged
Conversation
…sing (not portable)
…d::bad_alloc is thrown)
keithpotz
reviewed
Oct 7, 2026
keithpotz
left a comment
Owner
There was a problem hiding this comment.
See my comment on line 93 in CrashCatch.hpp. Let me know what you think and we can go from there.
dimhotepus
force-pushed
the
cleanup-src
branch
from
October 18, 2026 17:15
c870528 to
2fb998c
Compare
Contributor
|
I can confirm that these changes work fine on macOS 27 (on AArch64). |
keithpotz
approved these changes
Nov 10, 2026
keithpotz
left a comment
Owner
There was a problem hiding this comment.
All looks good and passed. Thank you for your contribution!
keithpotz
added a commit
that referenced
this pull request
Nov 10, 2026
Follow-up to PR #17 plus v1.6.0 release docs. Fixes: - shutdown() is now safe to call more than once or without initialize(); it no longer overwrites the app's own crash handlers - A second initialize() now only updates the config; before, it made shutdown() unable to restore the app's original handler - Windows: .dmp file is closed right after it's written, so it's no longer locked while the crash dialog is open - Windows: user32.lib is linked automatically (needed by MessageBoxW) - macOS: demangle() no longer throws or hangs on malformed backtrace lines inside the crash handler - macOS: atos command fixed to "atos -p <pid>" (was missing a space) C API: - crashcatch_shutdown(void) is now declared in the public header so C callers can use it - crashcatch_version() now returns "1.6.0" Docs: - New docs/macos.md page, added to the mkdoc - docs/index.md: macOS now listed as supported (platform table, features, requirements, roadmap) - CHANGELOG.md: new [1.6.0] entry - RELEASE.md: rewritten for v1.6.0 - README.md: fixed CrashCath::shutdown() typ now says v1.6.0 - mkdocs.yml: site description now includes macOS
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
A lot of changes from production usage.
Type of Change
How to Test
Default test suite.
Checklist