New Video Format - Squashed & memory management#171
Open
ffquintella wants to merge 38 commits intokekyo:developfrom
Open
New Video Format - Squashed & memory management#171ffquintella wants to merge 38 commits intokekyo:developfrom
ffquintella wants to merge 38 commits intokekyo:developfrom
Conversation
|
@kekyo Could you take a look please? |
Owner
|
@ffquintella Cart's #174 and #175 are merged, could you please rebase this fix onto the develop HEAD? Probably the easiest approach would be to squash the current series of commits on the Squashing into meaningful commit units would be best, but it's not required. |
|
I'll try out to carve out some time to do it today or tomorrow. |
|
Thank you for the reviews! |
Contributor
Author
|
DO you still need help ? |
|
@ffquintella I've been trying to split your work into several smaller PRs. This one is next #177. Could you take a look please? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds a new video format used on Mac, squashes some commits and fixes some memory management problems that where present on the old code.