Optimize I2C Library with Async/Await and Non-Blocking Streams #114
Conversation
- Add Promise-based `...Async` methods to the public API for modern `async/await` usage. - Refactor the `stream` method to be non-blocking. The polling logic has been moved from a blocking C++ `while` loop to a JavaScript `setInterval`. This improves performance by not blocking the Node.js event loop. - The native addon (`i2c.cc`) has been updated to remove the blocking `while` loop from the `ReadBlock` function.
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
This change introduces several optimizations to the I2C library. It adds Promise-based
Asyncmethods to the public API, allowing for the use ofasync/await. It also refactors thestreammethod to be non-blocking by moving the polling logic from C++ to JavaScript.PR created automatically by Jules for task 11930848292370998026 started by @kelly