Fix #36: replace HelpText with user-controllable announcements and visible text#155
Open
kellylford wants to merge 1 commit into
Open
Fix #36: replace HelpText with user-controllable announcements and visible text#155kellylford wants to merge 1 commit into
kellylford wants to merge 1 commit into
Conversation
… announcements and visible text - ComposeWindow: remove instructional HelpText from address field; deliver as a first-focus Hint announce (respects AnnounceHints setting) via new _addressHintGiven flag. Remove redundant HelpText from From combobox. - SettingsDialog: make F7/Shift+F7 spelling note visible (was hidden in HelpText); add visible TextBlock examples for spelling verbosity radio buttons; remove redundant HelpText from Log Format and Message Open Mode radio buttons that already have visible TextBlock descriptions. - NewFolderDialog: remove redundant HelpText (label is self-explanatory). - RulesManagerWindow: convert From/Body HelpText to visible TextBlocks; update Body AutomationProperties.Name to "Body preview contains" to surface the preview-only qualifier; remove HelpText from To and Subject fields. - AccountManagerDialog, AddAccountDialog: add visible "Stored in Windows Credential Manager." note below password field; update signature label to include "replies and forwards" so HelpText content is visible to all users. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #36 (partially — see issue comment for the remaining screen reader problem and options).
What this PR does
Replaces all
AutomationProperties.HelpTextentries that were invisible to sighted users with visible text, and routes the one long instructional string (address field tutorial) through the user-controllableAccessibilityHelper.Announcesystem instead.HelpTextfrom the address token field; delivers it as a first-focusHintannounce (_addressHintGivenflag, respectsAnnounceHintssetting). Removes redundantHelpTextfrom From combobox.TextBlock; spelling verbosity radio buttons now have visibleTextBlockexamples; redundantHelpTextremoved from Log Format and Message Open Mode radio buttons (those already had visible descriptions).HelpTextremoved.HelpTextconverted to visibleTextBlocknotes; BodyAutomationProperties.Nameupdated to "Body preview contains";HelpTextremoved from To and Subject fields.HelpTextis intentional keyboard shortcut metadata.Known limitation
The visible
TextBlockelements added by this PR are not in the tab order and are not automatically read by screen readers. A JAWS user needs the JAWS cursor; an NVDA user needs object navigation to reach them. This is a WPF platform limitation:AutomationProperties.DescribedBydoes not exist,GetDescribedByCore()is absent fromAutomationPeerin all .NET versions through .NET 10, andPasswordBoxis sealed. See the issue comment for the two options being considered for a follow-up pass.Test plan
AnnounceHintsoff in Settings — confirm address hint is suppressed🤖 Generated with Claude Code