feat(mint): implement programmable approval workflow engine#265
Merged
Conversation
- Add multi-step, role-based approval pipeline for cNGN mint requests - Tier logic: Tier1 (<1M NGN, 1 approval), Tier2 (1M-10M, 2 approvals), Tier3 (>10M, 3 approvals) - State machine: pending_approval -> partially_approved -> approved -> executed (or rejected/expired) - RBAC middleware: extract_identity + require_any_mint_role guards all mint endpoints - Self-approval prevention and duplicate approval prevention enforced in service layer - Rejection requires mandatory reason_code, immediately transitions to rejected - Execution guard: assert_executable() blocks on-chain tx unless fully approved - Immutable audit trail on every state change via mint_audit_log table - Mint expiry worker: auto-expires stale requests past 24h deadline (configurable poll interval) - Complete HTTP handlers: submit, approve, reject, get, list, audit endpoints - Correct HTTP status codes: 403 forbidden, 409 conflict, 400 bad request, 404 not found - DB schema: mint_requests, mint_approvals, mint_audit_log with indexes and triggers - Graceful shutdown support for expiry worker
|
@Harbduls Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #221