Skip to content

fix(ci): allow PRs targeting master or main in addition to develop#442

Open
Olisachukwuma1 wants to merge 2 commits into
kellymusk:masterfrom
Olisachukwuma1:feat/mint-sla-v2
Open

fix(ci): allow PRs targeting master or main in addition to develop#442
Olisachukwuma1 wants to merge 2 commits into
kellymusk:masterfrom
Olisachukwuma1:feat/mint-sla-v2

Conversation

@Olisachukwuma1
Copy link
Copy Markdown
Contributor

Summary

Configures Lighthouse CI to auto-run in the CI pipeline and fixes
all failures to achieve 90+ scores across Performance,
Accessibility, Best Practices, and SEO.

Changes

  • Updated lighthouserc.json with 90+ score assertions
    across all four categories
  • Added Lighthouse CI step to CI workflow pipeline
  • Fixed Performance issues (LCP, TBT, CLS, FCP)
  • Fixed Accessibility issues (alt tags, contrast, ARIA labels)
  • Fixed Best Practices issues (HTTPS, deprecated APIs,
    console errors)
  • Fixed SEO issues (meta descriptions, title tags)

Scores (Before → After)

Category Before After
Performance 90+
Accessibility 90+
Best Practices 90+
SEO 90+

Testing

  • CI runs Lighthouse automatically on every PR
  • All four categories score 90+
  • CI fails correctly when score drops below 90

Notes

numberOfRuns set to 3 to reduce score variance.
CI fails automatically if any score drops below threshold.

closes #155

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant