fix(#136): mobile-responsive wallet modals with bottom-sheet drawer#224
Open
Emmanard wants to merge 4 commits into
Open
fix(#136): mobile-responsive wallet modals with bottom-sheet drawer#224Emmanard wants to merge 4 commits into
Emmanard wants to merge 4 commits into
Conversation
Fix withdrawal lock release and payment test token cache resets.
…nd refactor modal views - Introduced a responsive drawer for mobile devices in the WalletModal component. - Refactored modal views into a separate WalletModalViews component for better organization. - Added WalletModalHeader for consistent header rendering across different modal variants. - Improved code structure and readability by utilizing TypeScript types for props.
|
@Emmanard is attempting to deploy a commit to the kelly musk's projects Team on Vercel. A member of the Team first needs to authorize it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
vaulDrawer sliding up from the bottom (rounded-t-2xl, drag handle,max-h-[90vh],pb-[env(safe-area-inset-bottom)]for iPhone home-bar)<Dialog>is untouched behind anisMobileguardWalletModalHeaderthat rendersDialogHeader/DialogTitle/DialogDescriptionon the dialog path and semantic<h2>/<p>on the sheet path — avoids running Radix Dialog context expectations inside a DrawerWalletModalViewsis shared by both shells so all four flows (connect, install, connecting, network-warning) live in one place<a>rowsmin-h-[56px]+active:state; Drawer close buttonmin-h-11 min-w-11(44 px); primary buttons alreadyh-12p-4 sm:p-6,text-xl sm:text-2xl,w-16 sm:w-20across all four viewsflex-col sm:flex-rowso buttons stack on narrow screenshooks/use-is-mobile.ts— hydration-safe (falseon SSR, real value post-mount viamatchMedia)Files changed
hooks/use-is-mobile.tsuseIsMobile()hookcomponents/Wallet/WalletModal.tsxTest plan
Closes #136