modified: ParticleConverter/MainWindow.xaml.cs#36
Open
Epic-Fox-1234 wants to merge 1 commit into
Open
Conversation
monckey100
suggested changes
Aug 28, 2024
monckey100
left a comment
There was a problem hiding this comment.
I compiled this version and there's a space between the particle and its nbt data:
particle minecraft:dust {color:[0.12, 0.06, 0.19] , scale: 0.75 } ^-1.28 ^3.84 ^0 0 0 0 0 1 force @a
should be:
particle minecraft:dust{color:[0.12, 0.06, 0.19] , scale: 0.75 } ^-1.28 ^3.84 ^0 0 0 0 0 1 force @a
just needs a space removed and then this can be pushed into main
|
any non devs who stumble upon here, I advise you learn how to compile projects on your own (hint: this is a visual studio project and you need to turn off package signing), but if you want to blindly trust me, here's the fixed version: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
changed dust particle format to match minecraft version 1.21