Repository navigation
Conversation
… a Source line Outside git, ROOT fell back to the working directory, so on a hosted chat with a sandbox the header named the project after a folder the host picked. Outside git, PROJECT now comes from a `project:<name>` token, or the current folder for a file destination, which is always on the user's own machine. A canvas or inline handoff with neither drops the slot. Inside git nothing changes, so resume by id still finds the same HANDOFF_DIR. Hosts with no session id now get a `Source: <paste this chat's URL>` line for the user to fill in, so the document keeps a way back to the chat. The suite refutes the old cwd fallback, because harpb's `|| echo "$PWD"` is how a sync would restore it. Part of #310.
… the cut cwd fallback The Deliberately Not Built row backs the new refute, since harpb's working-directory fallback is what an upstream sync would carry back in. Part of #310.
…inds the folder Outside git, a file handoff written with project:<name> lands under that name, but the printed invoke line had no token, so resume fell back to the current folder and looked in the wrong HANDOFF_DIR. The pointer now repeats the token. The suite also refutes harpb's own echo "$PWD" spelling of the cut fallback, and the two new ledger rows put their tier where the neighbouring rows do. Part of #310.
|
@codex review |
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: e21288650c
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
…ume still finds the file With no token, canvas and inline destinations had no PROJECT, so `handoff inline <id>` resuming a file written from the same folder looked in an undefined HANDOFF_DIR, even though resume ignores the inline flag. PROJECT is now the folder name on every destination, and only a canvas or inline header leaves it out, which is the part that could show a sandbox's name. The ledger, the Deliberately Not Built row, the provenance note, and the README follow the split. Part of #310.
Review of the resume fix found the Not Built row and the provenance note still read as if the folder fallback were cut outright. Both now say the cut is ROOT falling back to the working directory, which is what would put a sandbox's name back in the header. The suite pins the clause that drops the header's project slot, and the PROJECT bullet loses a duplicated clause. Part of #310.
|
@codex review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 9a59360944
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
The README dropped both conditions SKILL.md puts on the header omission, so it contradicted its own project:garage-shelving example and wrongly covered writes inside git. Part of #310.
|
@codex review |
|
Codex Review: Didn't find any major issues. Keep them coming! Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
Outside a git repo,
handoffno longer names the project after the working directory. On a hosted chat that folder is a sandbox name the host picked, so the header line labeled the document with something unrelated to the work. A host that exposes no session id now gets aSource: <paste this chat's URL>line, so the document keeps a way back to the chat it came from.Closes #310
What Changed
project:<name>token in the arguments, stripped before phase detection like the destination flags. Without the token, PROJECT is the current folder's name on every destination, so HANDOFF_DIR is always defined andhandoff inline <id>still resumes a file written from that folder. Only the header changes: a canvas or inline document written without the token drops the project slot,<datetime> · Agent: <name>, because that folder may be a sandbox the host picked.Then invoke: handoff <id> project:<name>), because resume finds HANDOFF_DIR through PROJECT and nothing else carries the name. In-session review caught this one: without it, a tokened file handoff couldn't be resumed from its own pointer.Session:andSource:under the header, with the rule that a document carries exactly one of them.tests/handoff-smoke.shpins seven strings and refutes two: the old "fall back to the current working directory if not in a git repo" and harpb'secho "$PWD", the form an upstream sync would bring back.[P]ledger rows and a Deliberately Not Built row for the cut fallback. PROVENANCE and the README each gain a line.Start with the ROOT, PROJECT and ARGS bullets in
_maintenance/handoff/template/SKILL.md, then the sentence after the file-pointer block.handoff/SKILL.mdis a render of the template.Verification
bash tests/handoff-smoke.shandbash tests/repo-docs-smoke.shpass at the baseline and at each gate, the last at27f831a, this branch's head. I didn't run the other 18 suites. A Sonnet reproducer that didn't author the change reproduced all 10 claims in round 1 and all 5 repair claims in round 2:bash tests/handoff-smoke.sh; echo exit $?→Generated skill is current: …/handoff/SKILL.md,exit 0.git archive HEADcopy with no.git, each refuted string appended to both SKILL.md files →exit 1andunexpected text in handoff/SKILL.md: fall back to the current working directory if not in a git repo, thenexit 1andunexpected text in handoff/SKILL.md: echo "$PWD". The clean copy exits 0.exit 1withmissing expected text in handoff/SKILL.md: …naming each.handoff inline <id>outside git with no token stripsinline, reads<id>as resume, sets PROJECT to the folder name and HANDOFF_DIR to<TMP>/agent-handoff/<folder>/, the same directory the file write used. A canvas or inline header written there still leaves the folder out.cmp handoff/SKILL.md _maintenance/handoff/template/SKILL.md→ identical.grep -nputs ROOT, PROJECT and ARGS at lines 18, 19 and 22,Session:andSource:at 122 and 123, and the pointer rule at 58, directly after the unchanged pointer block. Both ledger rows readlocal | [P] …like their neighbours, and the Not Built row names both refuted strings.Every seam claim is about prose, and nothing in the repo runs a model against the skill, so the suite is the closest production caller.
I also ran the text live, before the Codex repair. A fresh Sonnet agent read
handoff/SKILL.mdate212886and acted out five scenarios; the repair changes none of their outcomes:handoff inline project:garage-shelving …gave the header… · garage-shelving · Agent: Claudeand aSource:line.… · Agent: Claude, and the sandbox folder name appeared nowhere./tmp/agent-handoff/garage-shelving/, and its pointer endedproject:garage-shelving. Resuming from that pointer found the file.shelfapp / mainwithSession: abc123and noSource:line.The
adversarial-reviewtrigger printed authz on 9 changed lines. Seven are the English "where" and two are the unchanged "permission" sentence inside the edited paragraph after the template, so all 9 only mention the word, and the trigger didn't fire.Left Out
project: garage-shelving, with a space after the colon, isn't read as the token. The rule "Onlyproject:followed directly by a name is the token" is what keeps a prompt such ashandoff the project: field is wronga prompt.handoffdoesn't find a file that was written with a token, because it searches the folder-named directory. The printed pointer carries the token, andhandoff project:<name>resumes it.Source: <paste this chat's URL>. The issue asks for that on every host without a session id, and the skill has no reliable test for "this is a web chat".handoff inline project:<name>after a talk-only chat still resumes instead of writing. That's handoff: a barehandoff inlineafter a talk-only chat resumes instead of writing #311, next in the run order.