Add reset_expire#26
Open
alex88 wants to merge 1 commit into
Open
Conversation
|
|
||
| # Extends the expire time just in case process needs more time | ||
| def reset_expire | ||
| raise ExpireResetError, "extend_expire should be called only on locked resources" unless locked? |
Owner
There was a problem hiding this comment.
This should check the ownership of the lock by get == @expires_at.to_s instead of just locked?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is something that hopefully helps me solve #22.
Basically it lets the user add a safe guard in case the process that has acquired the lock dies (e.g. due SIGKILL) by being able to renew the lock expiration to a later time. I imagine the usage to be:
let me know if it's something you're interested in, in that case maybe the get+set has to be done in a single redis transaction and I should also add some docs in the readme. Otherwise I'll just keep the fork for our project