Skip to content

chore(deps): drop the unused direct vite devDependency - #328

Merged
keonik merged 1 commit into
mainfrom
chore/drop-unused-vite
Sep 3, 2026
Merged

keonik merged 1 commit into
mainfrom
chore/drop-unused-vite

Conversation

@keonik

@keonik keonik commented Sep 3, 2026

Copy link
Copy Markdown
Owner

Supersedes #323, which bumped this pin to ^8 instead of asking whether it should exist.

The pin was never used

Nothing in the repo imports vite. vitest.config.mts imports from vitest/config, and the only mention anywhere was line 130 of package.json. vitest declares vite in its own dependencies (not just peers):

deps.vite     = ^6.0.0 || ^7.0.0 || ^8.0.0
peerDeps.vite = ^6.0.0 || ^7.0.0 || ^8.0.0

so it installs and resolves vite with or without us.

What the pin actually cost

Holding ^6.0.0 while vitest wanted 7 meant the lockfile carried two of everything:

before                              after
"vite":        ["vite@6.4.3"]       "vite": ["vite@7.3.6"]
"vitest/vite": ["vite@7.3.6"]
esbuild@0.25.12 + esbuild@0.27.7    esbuild@0.27.7
  ...and @esbuild/* binaries for both platforms sets

Net -58 lines of bun.lock, one vite, one esbuild.

Verification

  • bun run build — OK
  • bun run test — 37/37 files, 70 passed, 1 skipped (unchanged from main)
  • bun run lint, bun run format:check — clean

No changeset: devDependencies are not published (files: ["dist"]), so this ships nothing to users.

Nothing in the repo imports vite. vitest declares it in its own
`dependencies` (^6.0.0 || ^7.0.0 || ^8.0.0) and resolves it itself, so
the direct pin only held us at ^6 while vitest wanted 7 — the lockfile
carried two copies:

    "vite":       ["vite@6.4.3"]
    "vitest/vite":["vite@7.3.6"]

and with them two esbuild trees (0.25.12 and 0.27.7) plus every
@esbuild/* platform binary for both. Removing the pin dedupes to a
single vite@7.3.6 and drops 58 lines of lockfile.

Closes #323, which bumped the pin to ^8 rather than removing it.
@keonik keonik added skip-changeset PR intentionally needs no changeset (docs/CI only) dependencies Pull requests that update a dependency file labels Sep 3, 2026
@keonik
keonik merged commit a44cbe1 into main Sep 3, 2026
26 checks passed
@keonik
keonik deleted the chore/drop-unused-vite branch September 3, 2026 14:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies Pull requests that update a dependency file skip-changeset PR intentionally needs no changeset (docs/CI only)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant