chore(deps): drop the unused direct vite devDependency - #328
Merged
Merged
Conversation
Nothing in the repo imports vite. vitest declares it in its own
`dependencies` (^6.0.0 || ^7.0.0 || ^8.0.0) and resolves it itself, so
the direct pin only held us at ^6 while vitest wanted 7 — the lockfile
carried two copies:
"vite": ["vite@6.4.3"]
"vitest/vite":["vite@7.3.6"]
and with them two esbuild trees (0.25.12 and 0.27.7) plus every
@esbuild/* platform binary for both. Removing the pin dedupes to a
single vite@7.3.6 and drops 58 lines of lockfile.
Closes #323, which bumped the pin to ^8 rather than removing it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Supersedes #323, which bumped this pin to
^8instead of asking whether it should exist.The pin was never used
Nothing in the repo imports
vite.vitest.config.mtsimports fromvitest/config, and the only mention anywhere was line 130 ofpackage.json. vitest declares vite in its owndependencies(not just peers):so it installs and resolves vite with or without us.
What the pin actually cost
Holding
^6.0.0while vitest wanted 7 meant the lockfile carried two of everything:Net
-58lines ofbun.lock, one vite, one esbuild.Verification
bun run build— OKbun run test— 37/37 files, 70 passed, 1 skipped (unchanged from main)bun run lint,bun run format:check— cleanNo changeset: devDependencies are not published (
files: ["dist"]), so this ships nothing to users.