Repository navigation
Fix create basis package resolution - #43
Merged
julienvincent merged 1 commit intoMar 8, 2026
Merged
julienvincent merged 1 commit into
julienvincent merged 1 commit into
Conversation
julienvincent
left a comment
julienvincent
left a comment
Contributor
There was a problem hiding this comment.
Thanks for taking the time to contribute a fix! I would however propose tackling this in a slightly different manner. See my comments below
Contributor
Author
|
@julienvincent |
julienvincent
approved these changes
Mar 8, 2026
julienvincent
left a comment
julienvincent
left a comment
Contributor
There was a problem hiding this comment.
LGTM, last thing; Please can you squash your commits into a single commit and give it a description. This is used for the changelog, and for having a clean history.
Alternatively, I can just squash everything on merge if you would prefer. Let me know.
Rewrites `create-basis` to replace `:local/root` workspace dependencies by iterating over the resolved basis `:libs` map instead of the package's `:depends-on` set. This ensures correct resolution even after `filter-by` clears `:depends-on`, and preserves non-workspace libs unchanged. Adds tests covering local dep replacement, filtered packages, non-workspace libs, and libs with no version.
itai-spiritt
force-pushed
the
fix-create-basis-package-resolution
branch
from
March 8, 2026 12:23
718166b to
731e9c6
Compare
Contributor
Author
|
done |
Contributor
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix for #41