Conversation
Naja now rejects creating an SNLInstance inside a primitive design. The miter and scope extraction tests built their top designs as primitives in the primitives library and instantiated gates in them, so 18 tests threw during netlist construction. Create the tops as standard designs in a standard library and keep only the leaf models as primitives. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
The previous pointer moved to naja main, which did not contain the shared Python runtime SDK commit that lived only on naja's fix7 branch. The Python package build depends on it (najaeda.sdk, NajaPythonRuntimeAPI.h, NLUniverse::getRuntimeIdentity, DNL::exchange). fix7 is now merged into naja main; point at that merge. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
Naja main keeps the upstream 0.7.26 version instead of the outdated 0.7.24.dev0 that came from the fix7 branch. Point the submodule at it and move the development provider pins to match. The development and published providers can now share a version number, so the wheel helper selects the published provider by KEPLER_USE_PUBLISHED_NAJAEDA rather than by a .dev suffix.
Pin naja to the current main, and naja-verilog and slang to the commits naja itself uses. Slang now comes from upstream. Route the new HDL and VHDL libraries through the Naja cc_library wrapper and add their directories to the quote include list.
Naja's VHDL frontend includes boost/multiprecision/cpp_int.hpp. The Windows setup installs Boost components individually through vcpkg and did not include it, so the NajaEDA provider wheel failed to build on Windows only.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.