Conversation
Issue #250, third report: on Systolic_MAC_with_DFT the self compare covered 15 of 24 outputs. The result array is written by one always block per element from a generate loop. naja's memory inference made the first block the memory's write port and lowered the second as a flop, so the memory's read data net had two drivers and every cone through it was unverifiable. naja main now leaves an array with several writer blocks to the generic sequential lowering (nanocoh/naja bca04489). The design proves 24 of 24 outputs at k = 1. A CLI test adds the pattern as a self compare gated on full coverage, next to the two earlier #250 tests.
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #250, third report: on Systolic_MAC_with_DFT the self compare covered 15 of 24 outputs. The result array is written by one always block per element from a generate loop. naja's memory inference made the first block the memory's write port and lowered the second as a flop, so the memory's read data net had two drivers and every cone through it was unverifiable.
naja main now leaves an array with several writer blocks to the generic sequential lowering (nanocoh/naja bca04489). The design proves 24 of 24 outputs at k = 1. A CLI test adds the pattern as a self compare gated on full coverage, next to the two earlier #250 tests.