Repository navigation
Bind the Python package to NajaEDA through its shipped headers - #263
Merged
Merged
Conversation
The naja fork now ships only the headers matching its wheel's libraries (najaeda/sdk/include) instead of the shared-runtime SDK. Replace the SDK path and the separate published-wheel adapter with one provider path: naja_provider.py resolves the installed package's libraries and headers (or the 0.7.24 source archive with KEPLER_USE_PUBLISHED_NAJAEDA), KeplerSharedNaja.cmake creates the imported targets, and KeplerNajaRuntime.cpp checks the provider's version, git hash, file hashes, exported Python types and live universe before borrowing a design through its wrapper. The DNL singleton is swapped through naja's exported dnlFull_ in both modes. Re-sign the installed extension on macOS: CMake's install RPATH rewrite invalidated the fixup's ad-hoc signature, so a plain pip install was killed at import on Apple Silicon. Update the submodule to fork main (ad34893b, NajaEDA 0.7.27) and the development provider pins to 0.7.27.
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The naja fork now ships only the headers matching its wheel's libraries (najaeda/sdk/include) instead of the shared-runtime SDK. Replace the SDK path and the separate published-wheel adapter with one provider path: naja_provider.py resolves the installed package's libraries and headers (or the 0.7.24 source archive with KEPLER_USE_PUBLISHED_NAJAEDA), KeplerSharedNaja.cmake creates the imported targets, and KeplerNajaRuntime.cpp checks the provider's version, git hash, file hashes, exported Python types and live universe before borrowing a design through its wrapper. The DNL singleton is swapped through naja's exported dnlFull_ in both modes.
Re-sign the installed extension on macOS: CMake's install RPATH rewrite invalidated the fixup's ad-hoc signature, so a plain pip install was killed at import on Apple Silicon.
Update the submodule to fork main (ad34893b, NajaEDA 0.7.27) and the development provider pins to 0.7.27.