Repository navigation
Conversation
"Difference was found. Please refer to the log(miter_log_x.txt)" named a placeholder: the miter log is miter_log_<n>.txt with the first free n, or the configured log_file. The three LEC verdicts (whole design, scopes, compact snapshots) now name MiterStrategy::getActualLogFileName(). LecDifferenceNamesTheMiterLogItWrote runs a differing pair, finds the named file and checks it holds the miter's lines. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
oharboe
force-pushed
the
lec-log-names-miter-log
branch
from
October 6, 2026 08:00
aa44e76 to
e4982cc
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The LEC verdict says "Difference was found. Please refer to the log(miter_log_x.txt)" with a literal
x. The miter log is actuallymiter_log_<n>.txtwith the first freen, or the configuredlog_file, so a user has to guess which file it is. The three LEC verdicts (whole design, scopes, compact snapshots) now nameMiterStrategy::getActualLogFileName().Test:
KeplerCliSubprocessTests.LecDifferenceNamesTheMiterLogItWroteinMiterTestsruns the binary on a differing pair. It reads the file name from the verdict and checks that the file exists and holds the miter's lines. It passes underbazel testin about a second.🤖 Generated with Claude Code