Repository navigation
Conversation
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Standard gate symbols, and a rework of how the schematic is laid out and wired.
Gate type and clock pins from naja's modeling
primitive_typenow also comes withresolve_instance/instance_resolved, so an instance shown on its own (focus_instance, "Show Instance") gets its gate symbol, not a box."clock": trueon a sequential cell's clock pin, so the DFF clock notch appears after "show all pins" too.SNLDesignModeling, never from cell or pin names.LocalSNLProvider.cppandprotocol.pyare kept in step, with tests.scripts/gate_shapes_example.v: a small gate-level design with one instance of every recognized primitive, to check the symbols.Schematic layout
The layout follows the usual schematic-generation pipeline. It lives in
SchematicLayout, which is pure geometry with unit tests.symbolGeometry): every pin sits on a 20-unit grid.layeredPlacement, replacingIncrementalLayout):routeNets): one orthogonal tree per driving pin.Behavior change
The layout is now recomputed from scratch every frame instead of built up net by net. It is deterministic, and ordering ties follow the order nets first appeared in, so nothing moves unless the nets change. But adding a net can shift boxes that are already drawn. A pin click still keeps the clicked box in place on screen.
Wiring inside an instance expanded in place (the +/- button) keeps its old simple drawing.
Tests
SchematicLayoutTest: symbols, placement (straight chains, fan-in order, feedback, no overlaps on a random graph, determinism), port stacking, and routing (straight wires, junctions, separate tracks, same-height horizontals, detours, spine separation).EquipotentialViewTest) pass unchanged.🤖 Generated with Claude Code