Make bucket force_destroy configurable#211
Conversation
There was a problem hiding this comment.
Code Review
This pull request introduces a force_destroy configuration for GCS buckets, allowing users to control whether buckets are automatically emptied during teardown. It adds a --force-destroy/--no-force-destroy CLI option to the up command, implements state persistence for this setting, and ensures it is correctly propagated to the underlying Pulumi infrastructure. The implementation follows the repository's precedence rules (CLI flag > existing state > default) and includes comprehensive unit tests. I have no feedback to provide as there were no review comments to evaluate.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #211 +/- ##
=======================================
Coverage ? 90.56%
=======================================
Files ? 67
Lines ? 10235
Branches ? 0
=======================================
Hits ? 9269
Misses ? 966
Partials ? 0 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Adds
--force-destroy/--no-force-destroy(env:KINETIC_FORCE_DESTROY) tokinetic up. The setting is persisted viapulumi.exportand read back byload_state, sopool add/removepreserve it instead of silently reverting. Default staysforce_destroy=True.#23 bundles 5 separate config requests. This PR addresses the first (force_destroy on pulumi resources). The other 4 (multi-GPU node pools, pulumi state backend, stateful CLI configs, CLI config updates) are out of scope for this PR.