Skip to content

Make bucket force_destroy configurable#211

Open
MarcosAsh wants to merge 1 commit intokeras-team:mainfrom
MarcosAsh:configurable-bucket-force-destroy
Open

Make bucket force_destroy configurable#211
MarcosAsh wants to merge 1 commit intokeras-team:mainfrom
MarcosAsh:configurable-bucket-force-destroy

Conversation

@MarcosAsh
Copy link
Copy Markdown
Contributor

Adds --force-destroy/--no-force-destroy (env: KINETIC_FORCE_DESTROY) to kinetic up. The setting is persisted via pulumi.export and read back by load_state, so pool add/remove preserve it instead of silently reverting. Default stays force_destroy=True.

#23 bundles 5 separate config requests. This PR addresses the first (force_destroy on pulumi resources). The other 4 (multi-GPU node pools, pulumi state backend, stateful CLI configs, CLI config updates) are out of scope for this PR.

Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces a force_destroy configuration for GCS buckets, allowing users to control whether buckets are automatically emptied during teardown. It adds a --force-destroy/--no-force-destroy CLI option to the up command, implements state persistence for this setting, and ensures it is correctly propagated to the underlying Pulumi infrastructure. The implementation follows the repository's precedence rules (CLI flag > existing state > default) and includes comprehensive unit tests. I have no feedback to provide as there were no review comments to evaluate.

@codecov-commenter
Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 95.83333% with 4 lines in your changes missing coverage. Please review.
⚠️ Please upload report for BASE (main@8a85c3c). Learn more about missing BASE report.

Files with missing lines Patch % Lines
kinetic/cli/infra/stack_manager.py 20.00% 4 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main     #211   +/-   ##
=======================================
  Coverage        ?   90.56%           
=======================================
  Files           ?       67           
  Lines           ?    10235           
  Branches        ?        0           
=======================================
  Hits            ?     9269           
  Misses          ?      966           
  Partials        ?        0           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants