Bound camera RPC waits and feed shutdown - #2
Open
walker2398 wants to merge 3 commits into
Open
walker2398 wants to merge 3 commits into
walker2398 wants to merge 3 commits into
Conversation
walker2398
marked this pull request as ready for review
August 2, 2026 11:14
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Root cause
Camera RPCs previously had no deadlines.
close_camera_feed()attempted to enforce a ten-second limit with a polling loop, but eachimage_streaming_enabled()call used an unboundedfuture.result(). A delayed robot or network could therefore block shutdown indefinitely. Cancelling the task also did not explicitly cancel the wrapped gRPC iterator.This change intentionally keeps the existing gRPC transport and public behavior. It does not add an HTTP fallback or another camera workflow.
Validation
anki_vector/camera.pycompiles successfullygit diff --check2.0.1.6076ep: capture returned 640x360 in 0.797 seconds; CameraFeed delivered a frame; close completed in 0.409 seconds;IsImageStreamingEnabledreturned false afterward