Skip to content

ci: use CURSOR_PREFERRED_MODEL secret instead of hardcoded model #138

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
masnwilliams merged 1 commit into from
Mar 23, 2026
+1 −1
Merged

ci: use CURSOR_PREFERRED_MODEL secret instead of hardcoded model #138

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/fix-ci.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -102,4 +102,4 @@ jobs:
- Avoid duplicate comments - update existing bot comments
- If no actionable fix is possible, make no changes and post no comment
- PR comments must ONLY include the PR creation link, no manual merge instructions
" --model opus-4.5 --force --output-format=text
" --model ${{ secrets.CURSOR_PREFERRED_MODEL }} --force --output-format=text
Copy link

@cursor cursor bot Mar 23, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing secret causes model flag to consume next argument

Medium Severity

If the CURSOR_PREFERRED_MODEL secret is not configured (or is empty), ${{ secrets.CURSOR_PREFERRED_MODEL }} resolves to an empty string. The shell would then parse --model --force, causing --force to be consumed as the model name. Unlike the other secrets in this workflow (which fail clearly at their respective steps), this would produce a confusing error from cursor-agent. Adding a default fallback like ${{ secrets.CURSOR_PREFERRED_MODEL || 'opus-4.5' }} would preserve the previous behavior when the secret is unset.

Fix in Cursor Fix in Web

Loading