Skip to content

ci: use CURSOR_PREFERRED_MODEL secret instead of hardcoded model #33

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
masnwilliams merged 1 commit into from
Mar 23, 2026
Merged

ci: use CURSOR_PREFERRED_MODEL secret instead of hardcoded model #33

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/update-cli-coverage.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -365,4 +365,4 @@ jobs:
- Streaming methods may have different CLI implementations (e.g., build events are streamed internally)
- Even if no coverage gaps are found, still create a PR for the SDK version bump
- Ensure code compiles before pushing
" --model gpt-5.3-codex-high --force --output-format=text
" --model ${{ secrets.CURSOR_PREFERRED_MODEL }} --force --output-format=text
Copy link

@cursor cursor bot Mar 23, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Empty model flag if secret is unset

Medium Severity

If the CURSOR_PREFERRED_MODEL secret is not configured (or is later removed), ${{ secrets.CURSOR_PREFERRED_MODEL }} silently evaluates to an empty string in GitHub Actions. This causes --model to receive no value, likely making the CLI misinterpret --force as the model name or error out. There's no default fallback or validation to prevent this silent failure.

Fix in Cursor Fix in Web

Loading