fix: image surfaces and dry-run reclaim semantics#161
Merged
sjmiller609 merged 2 commits intomainfrom Mar 23, 2026
Merged
Conversation
Collaborator
Author
|
taking liberty to merge small fixes |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Testing
go test ./lib/images -run "Test(ListImages_IncludesDigestOnlyImages|DeleteImageByDigest)" -count=1go test ./lib/guestmemory -run TestTriggerReclaimDryRunDoesNotReportAppliedReclaim -count=1go test ./cmd/api/api -run "Test(ListImages_FilterByTagsIncludesDigestOnlyImages|DeleteImage_DigestOnlyImageDoesNotInternalError)" -count=1deft-kernel-devafter bootstrap:go test ./lib/images ./lib/guestmemory ./cmd/api/api -count=1Notes
Note
Medium Risk
Medium risk because it changes image storage enumeration and deletion semantics (including digest-based deletes) and adjusts reclaim accounting, which could affect user-visible API behavior and disk cleanup edge cases.
Overview
Images: Listing/metrics now enumerate images by digest
metadata.json(not just tag symlinks), so digest-only images appear inListImagesand tag filtering. Deletion now supports digest references by removing any tags pointing at the digest and deleting the digest directory under a repository, with locking moved to cover tag resolution/removal and orphan checks.Guest memory reclaim:
dryRunno longer reportsAppliedReclaimBytes(response or per-action) and avoids implying reclaimed memory unless a target was actually applied.Tests/docs: Adds API and manager regression tests plus helpers for seeding digest-only metadata, adds a dry-run reclaim test, and appends branch verification notes in
skills/test-agent/agents/test-agent/NOTES.md.Written by Cursor Bugbot for commit 84e2c22. This will update automatically on new commits. Configure here.