[kernel-1116] browser logging: Event Schema & Pipeline#184
[kernel-1116] browser logging: Event Schema & Pipeline#184archandatta wants to merge 5 commits intomainfrom
Conversation
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
| mu sync.RWMutex | ||
| buf []BrowserEvent | ||
| head int // next write position (mod cap) | ||
| count int // items currently stored (0..cap) |
There was a problem hiding this comment.
RingBuffer count field is maintained but never read
Low Severity
The count field in RingBuffer is declared, incremented in Publish, but its value is never consumed by any reader-facing logic. The oldestSeq function — the only place that needs to know buffer occupancy — derives the answer from written and len(rb.buf) instead. This makes count dead state that adds confusion about the ring buffer's invariants.
Additional Locations (1)
09ed5ed to
29f2bbf
Compare
rgarcia
left a comment
There was a problem hiding this comment.
nice direction on the pipeline/schema. one thing i'd consider before cementing BrowserEvent v1: if this is eventually going to drive both capture controls (for example: "turn on cdp console only" or "turn on network request/response capture at headers-only detail") and subscriptions, it might be worth making those selector dimensions first-class in the envelope instead of encoding too much into a single type string.
concretely, i think i'd lean toward:
- keeping the primary event identity semantic, e.g.
console.log,network.request,input.click - adding explicit provenance fields like
source_kind(cdp,kernel_api,extension,local_process) plussource_name/source_event(for exampleRuntime.consoleAPICalled) - adding an explicit
detail_level(minimal,default,verbose,raw) - possibly making
categoryfirst-class too instead of deriving it from the type prefix
i probably would not use raw Runtime.* / Network.* as the primary type, since that makes future non-cdp producers feel awkward/second-class. i think the semantic-type + provenance split ages better if we later want to emit events from things like:
- third-party extensions running in the browser and talking to localhost
- vm-local helper processes/programs running alongside the browser
- server/api-driven tool actions like screenshot/input/recording events
that shape also gives the system a much more natural control surface for both capture config and subscriptions, since selectors can operate directly on stable fields like category, topic, source_kind, and detail_level instead of needing to parse overloaded event names.


Note
Medium Risk
Adds a new concurrent event ingestion pipeline with file I/O and truncation behavior; risks are mainly around correctness under load (dropped-event signaling, write ordering, and silent file-write failures).
Overview
Introduces a new
server/lib/eventspackage implementing the browser logging pipeline end-to-end: a canonicalBrowserEventschema with category routing and size-based truncation, a non-blocking fan-outRingBufferthat can emit a syntheticevents_droppedevent when readers fall behind, and a per-category JSONLFileWriterthat lazily opens and appends to*.logfiles.Adds a
Pipelinewrapper that stampsCaptureSessionID, monotonicSeq, andTs, applies truncation before both sinks, writes durably to disk before publishing in-memory, and provides reader subscriptions; comprehensive tests cover JSON encoding, routing, concurrency, overflow/drop behavior, and truncation limits.Written by Cursor Bugbot for commit 29f2bbf. This will update automatically on new commits. Configure here.