Skip to content

fix: reduce live view scroll sensitivity #188

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
hiroTamada wants to merge 6 commits into
base: main
Choose a base branch
from
Open

fix: reduce live view scroll sensitivity #188

Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
295e90e
fix: reduce live view scroll sensitivity
hiroTamada Mar 24, 2026
bd277cc
fix: wire scroll sensitivity setting to polling interval
hiroTamada Mar 24, 2026
e6d0eb6
fix: clear scroll interval on component destroy
hiroTamada Mar 24, 2026
2c6ab92
fix: use proportional scaling for scroll ticks instead of direction-only
hiroTamada Mar 24, 2026
f4bd9ef
fix: guard scroll interval callback against hosting/locked state changes
hiroTamada Mar 24, 2026
08a3238
fix: simplify scroll fix to minimal divisor approach
hiroTamada Mar 24, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 3 additions & 7 deletions images/chromium-headful/client/src/components/video.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -712,11 +712,6 @@
let x = e.deltaX
let y = e.deltaY

// Pixel units unless it's non-zero.
// Note that if deltamode is line or page won't matter since we aren't
// sending the mouse wheel delta to the server anyway.
// The difference between pixel and line can be important however since
// we have a threshold that can be smaller than the line height.
Copy link
Contributor

@rgarcia rgarcia Mar 25, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this comment seems useful? and maybe should be expanded with the change in this pr

if (e.deltaMode !== 0) {
x *= WHEEL_LINE_HEIGHT
y *= WHEEL_LINE_HEIGHT
Expand All @@ -727,8 +722,9 @@
y = y * -1
}

x = Math.min(Math.max(x, -this.scroll), this.scroll)
y = Math.min(Math.max(y, -this.scroll), this.scroll)
const PIXELS_PER_TICK = 120
x = x === 0 ? 0 : Math.min(Math.max(Math.round(x / PIXELS_PER_TICK) || Math.sign(x), -this.scroll), this.scroll)
y = y === 0 ? 0 : Math.min(Math.max(Math.round(y / PIXELS_PER_TICK) || Math.sign(y), -this.scroll), this.scroll)

this.sendMousePos(e)

Expand Down
Loading