Repository navigation
Tests: the whatif fixture's preamble claim, without startup - #6
Merged
Merged
Conversation
Claim 7 said the preamble is the longest phase on every engine. On LuaLaTeX the engine's startup is about as long as this preamble: 207 against 224 ms here, 363 against 361 ms on a CI runner, where the fixtures are rebuilt before the tests. The claim is now that the preamble is longer than every phase after it, which holds by more than ten times.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the TeX job failing at random on whatif_fixture_bounds. The test compared the preamble with LuaLaTeX's startup, which is about the same size (363 against 361 ms on the runner that failed #5). It now compares the preamble with the phases after it, which it beats by more than ten times.