fix(ci): two born-broken #2420 tests (RoleTierChips text nodes + SectionLabel CSSOM serialization) - #2429
Merged
Merged
Conversation
- RoleTierChips rendered `{k} · {v}` as three text nodes, so the test's
exact-text queries (`code · none`) could never match. One template-
literal text node — the tests pass as written and the DOM is cleaner.
- SectionLabel.test asserted letterSpacing ".08em", but CSSOM serializes
the value with its leading zero ("0.08em") — assert the canonical form.
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
… + scoped globs) The single-text-node fix exposed the real mismatch: the test asserted the conceptual #219 table (planner code:none), but role-capabilities.json encodes plan-only as code:write + writeGlobs scoped to plan-section files (*.md, prompts/*, ...) — unlike the director, whose commons carve-out is encoded code:none + globs (#851). The data drives real permission wiring, so the test aligns with the model, with the encoding asymmetry documented. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Develop went red again minutes after #2415: PR #2427 merged past the red gate carrying two #2420 tests that never ran green — RoleTierChips' exact-text queries can't match across three JSX text nodes (now one template literal), and SectionLabel's letterSpacing assertion expected
.08emwhere CSSOM serializes0.08em. Both PRs #2398/#2399 failed identically on these, confirming base rot.🤖 Generated with Claude Code