fix(blueprints,#236): read soundKit/h/origin/updatedAt; sync stale category drift - #267
Open
kevinthelago wants to merge 1 commit into
Open
fix(blueprints,#236): read soundKit/h/origin/updatedAt; sync stale category drift#267kevinthelago wants to merge 1 commit into
kevinthelago wants to merge 1 commit into
Conversation
…tegory drift blueprintsPage.ts (the previously-live consumer) is orphaned (unreachable from any app/ route per CLAUDE.md's tech-debt table) and out of this session's write scope, so the contract fix lands as a new mirror/blueprintsView.ts selector instead: verified live against base-studio-code develop's storeProjections.ts, it reads soundKit/h/origin/ updatedAt (the #236 gap) and drops `category`, which no longer exists on the real wire. storePayloads.fixtures.json's blueprints entries carried a stale `category` field the desktop stopped emitting — removed to match the verified real fixture. h/origin/updatedAt are read but not yet exercised by the canonical fixture (an upstream fixture-input gap, the same class as the documented `components` C1 debt); blueprintsView.test.ts closes that coverage gap with hand-written payloads, the same pattern designPage.test.ts uses for themes.base. blueprints moves from PENDING_DOMAINS to DECODERS in the payload-parity harness (#234). Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01RTa8jiVAwxGBwoYtBQyanB
📦 Preview build readyArtifact: Built from commit 95cac10 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes the
blueprintschild of #234 (payload-parity resync umbrella).blueprintsPage.ts(the previously-live consumer of this domain) is orphaned —unreachable from any
app/route per CLAUDE.md's Known Issues & Tech Debt table — andis outside this session's write scope (
bsc-scope#1297 grants onlysrc/lib/mirror/**,src/lib/types.ts,src/lib/tunnel/*). So the contract fix landsas a new
src/lib/mirror/blueprintsView.tsselector instead, verified live againstbase-studio-code
develop'sstoreProjections.ts(BlueprintCard/buildBlueprintsPayload). It readssoundKit/h/origin/updatedAt— the blueprints domain: soundKit/h/origin/updatedAt unread; only the ACTIVE team crosses the wire #236 gap —and deliberately does not read
category, which no longer exists on the real wire.storePayloads.fixtures.json'sblueprintsentries (bothdomains.blueprintsand theblueprints_no_teamvariant) carried a stalecategoryfield the desktop stoppedemitting. Removed to match the verified real fixture (fetched live from
base-studio-code@develop, byte-compared).h/origin/updatedAtare read by the new selector but not yet exercised by thecanonical fixture — an upstream fixture-input gap, the same class of debt already
documented for
components(C1) in this harness.blueprintsView.test.tscloses thecoverage gap with hand-written payloads, the same pattern
designPage.test.tsuses forthemes.base.blueprintsmoves fromPENDING_DOMAINStoDECODERSin the payload-parity harness.Whichever surface reconnects the blueprints domain next (#233's Studio/Teams segment)
should import from
mirror/blueprintsView.ts, not the orphanedpages/blueprintsPage.ts.Test plan
npx tsc --noEmit— cleannpm test— 542/542 passing (63 suites), including the newblueprintsView.test.tsand the
blueprintsLayer A/B harness entriesbase-studio-code@develop(not guessed)Co-Authored-By: Claude Sonnet 5 noreply@anthropic.com
Claude-Session: https://claude.ai/code/session_01RTa8jiVAwxGBwoYtBQyanB