Switch from PIP to XML format for SDN data #33
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OFAC discontinued the pipe-delimited (.pip) files on September 25, 2023. This updates the gem to download and parse the XML format from: https://www.treasury.gov/ofac/downloads/sdn.xml Key changes: - Use Nokogiri for XML parsing with namespace handling - Preserve the same denormalization behavior (address x alias records) - Keep MySQL bulk import and ActiveRecord fallback paths - Add proper HTTPS redirect handling for downloads Also updates test infrastructure for Ruby 3.4 and Rails 8: - shoulda-context instead of deprecated shoulda gem - Fix File.exists? -> File.exist? deprecation - Update migrations to versioned format - Use in-memory SQLite for tests Fixes kevintyll#32
Wrap config.assets.debug in respond_to? check to handle cases where sprockets is not loaded in the dummy app environment.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #32 — OFAC discontinued the pipe-delimited (.pip) files on September 25, 2023, which means the gem has been politely failing to download anything useful for a while now.
I opened issue #32 back when I first hit the
Trouble downloading fileerror, and finally got around to implementing a fix. This PR updates the gem to use the XML format that OFAC still actively maintains:https://www.treasury.gov/ofac/downloads/sdn.xml
Changes
Core Implementation
Test Infrastructure
Updated for Ruby 3.4 / Rails 8 compatibility, because time marches on:
shouldagem withshoulda-contextFile.exists?→File.exist?(Ruby 3.4 finally got tired of warning us)Documentation
Test Results
All 26 tests pass (77 assertions). The existing test assertions were preserved — if it worked before, it still works now, just with XML instead of pipes.
Version
Bumped to 3.1.0 — minor version since the public API is unchanged. That said, if you'd prefer 4.0.0 given that the underlying data source changed entirely, that's a reasonable call too.
Thanks for maintaining this gem! It's been quietly useful to a lot of folks checking names against the SDN list.