Support for module partitions, filter os-specific files#72
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR updates the GBS build pipeline to better support C++20 modules (including module partitions) and to filter OS-specific source files/directories based on the target OS.
Changes:
- Extend dependency scanning and build orchestration to account for module partitions and (some) WSL path cases.
- Add target-OS-aware source inclusion filtering (windows/linux/macos directories) and update callers to pass
context. - Update task graph execution to support task failure/abort signaling and add cycle detection diagnostics.
Reviewed changes
Copilot reviewed 15 out of 15 changed files in this pull request and generated 11 comments.
Show a summary per file
| File | Description |
|---|---|
launch.vs.json |
Adds/adjusts VS launch profiles for running builds/tests. |
gbs/src/task/task_graph.cpp |
Adds cycle detection output; changes task execution to return bool and abort on failure. |
gbs/inc/task/task_graph.h |
Updates task API to bool-returning work items; adds cycle-path helper and abort state. |
gbs/inc/task/task.h |
Changes task work signature to bool; adds task_true. |
gbs/src/os.cpp |
Removes host-OS helpers now inlined in header. |
gbs/inc/os.h |
Inlines is_host_* consteval helpers. |
gbs/src/get_source_groups.cpp |
Adds OS-specific filtering and threads context through source enumeration. |
gbs/inc/get_source_groups.h |
Updates APIs to accept context. |
gbs/src/dep_scan.cpp |
Adds module partition parsing and WSL-path handling during dependency scan. |
gbs/inc/dep_scan.h |
Updates dependency-scan API to accept context. |
gbs/src/cmd_build.cpp |
Integrates new filtering + dependency scan; adds module dependency edges; changes tasks to return bool. |
gbs/src/enumerate_compilers_clang.cpp |
Makes temp file removal non-throwing; gates WSL enumeration to Windows. |
gbs/src/enumerate_compilers.cpp |
Adds os.h include (context for host/OS utilities). |
gbs/src/context.cpp |
Adjusts MSVC flags and enables clang std-module patching on Windows hosts. |
.github/workflows/cmake-multi-platform.yml |
Adds a Windows CI step that downloads and runs GBS to build + run unittests. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 15 out of 15 changed files in this pull request and generated 4 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Contributor
4 tasks
…orking/gbs into Support-for-module-partitions
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.