Skip to content

Support for module partitions, filter os-specific files#72

Merged
kgorking merged 25 commits into
masterfrom
Support-for-module-partitions
Mar 11, 2026
Merged

Support for module partitions, filter os-specific files#72
kgorking merged 25 commits into
masterfrom
Support-for-module-partitions

Conversation

@kgorking

Copy link
Copy Markdown
Owner

No description provided.

@kgorking kgorking self-assigned this Mar 11, 2026
@kgorking kgorking added the enhancement New feature or request label Mar 11, 2026
Copilot AI review requested due to automatic review settings March 11, 2026 05:37

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the GBS build pipeline to better support C++20 modules (including module partitions) and to filter OS-specific source files/directories based on the target OS.

Changes:

  • Extend dependency scanning and build orchestration to account for module partitions and (some) WSL path cases.
  • Add target-OS-aware source inclusion filtering (windows/linux/macos directories) and update callers to pass context.
  • Update task graph execution to support task failure/abort signaling and add cycle detection diagnostics.

Reviewed changes

Copilot reviewed 15 out of 15 changed files in this pull request and generated 11 comments.

Show a summary per file
File Description
launch.vs.json Adds/adjusts VS launch profiles for running builds/tests.
gbs/src/task/task_graph.cpp Adds cycle detection output; changes task execution to return bool and abort on failure.
gbs/inc/task/task_graph.h Updates task API to bool-returning work items; adds cycle-path helper and abort state.
gbs/inc/task/task.h Changes task work signature to bool; adds task_true.
gbs/src/os.cpp Removes host-OS helpers now inlined in header.
gbs/inc/os.h Inlines is_host_* consteval helpers.
gbs/src/get_source_groups.cpp Adds OS-specific filtering and threads context through source enumeration.
gbs/inc/get_source_groups.h Updates APIs to accept context.
gbs/src/dep_scan.cpp Adds module partition parsing and WSL-path handling during dependency scan.
gbs/inc/dep_scan.h Updates dependency-scan API to accept context.
gbs/src/cmd_build.cpp Integrates new filtering + dependency scan; adds module dependency edges; changes tasks to return bool.
gbs/src/enumerate_compilers_clang.cpp Makes temp file removal non-throwing; gates WSL enumeration to Windows.
gbs/src/enumerate_compilers.cpp Adds os.h include (context for host/OS utilities).
gbs/src/context.cpp Adjusts MSVC flags and enables clang std-module patching on Windows hosts.
.github/workflows/cmake-multi-platform.yml Adds a Windows CI step that downloads and runs GBS to build + run unittests.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread gbs/src/task/task_graph.cpp
Comment thread gbs/src/task/task_graph.cpp
Comment thread gbs/src/cmd_build.cpp Outdated
Comment thread gbs/src/cmd_build.cpp
Comment thread gbs/src/dep_scan.cpp
Comment thread gbs/src/cmd_build.cpp Outdated
Comment thread gbs/inc/task/task_graph.h
Comment thread gbs/inc/task/task_graph.h
Comment thread gbs/src/task/task_graph.cpp Outdated
Comment thread launch.vs.json
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Copilot AI review requested due to automatic review settings March 11, 2026 05:50

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 15 out of 15 changed files in this pull request and generated 4 comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread gbs/inc/task/task_graph.h
Comment thread gbs/src/cmd_build.cpp Outdated
Comment thread gbs/inc/task/task_graph.h
Comment thread gbs/src/cmd_build.cpp Outdated

Copilot AI commented Mar 11, 2026

Copy link
Copy Markdown
Contributor

@kgorking I've opened a new pull request, #73, to work on those changes. Once the pull request is ready, I'll request review from you.

@kgorking kgorking merged commit 45282e9 into master Mar 11, 2026
5 checks passed
@kgorking kgorking deleted the Support-for-module-partitions branch March 11, 2026 06:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants