meeting-recorder: style the panel with crow's own tokens - #338
Merged
Conversation
The panel shipped with invented CSS variable names (--surface, --border,
--text-muted, --accent). None of them exist, so every fallback applied and
the panel rendered as white cards with muted grey labels inside the dark
dashboard. The checkboxes were worse: the base sheet's "input { width:100% }"
stretched each one across its row and shoved the label text to the far right.
Now it uses --crow-* tokens and the dashboard's own .card, .btn and
.data-table classes, with one deliberate override giving checkboxes their
natural width. Hints sit under their labels rather than running on inline.
Verified by rendering the panel through renderLayout() and screenshotting it
in both schemes; dark mode was the one that was broken and is the one shown
in the report.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The panel shipped in #336 looked fine as a standalone page and wrong inside the dashboard. Two causes, both mine:
Invented CSS variables. The panel styled itself with
--surface,--border,--text-mutedand--accent. Crow defines none of them, so every fallback applied and the panel rendered as white cards with muted grey labels sitting inside the dark dashboard. Fallback values fail silently, which is what made it look like a theme bug rather than a typo.The checkbox rule. The base sheet sets
input, textarea, select { width: 100%; padding: 0.6rem }, which catchesinput[type=checkbox]too: each box stretched across its row and pushed its label text to the far right edge.Now the panel uses
--crow-*tokens and the dashboard's own.card,.btn,.btn-primaryand.data-tableclasses, so it follows the theme instead of re-declaring one. Checkboxes get an explicitwidth: autooverride, and the hint text under each source label is a block rather than running on inline.Verified by rendering the panel through
renderLayout()into a static page and screenshotting it withprefers-color-schemeemulated in both directions. Dark mode was the broken one and now matches the rest of the dashboard: dark cards, readable labels, correctly sized checkboxes, accent-coloured primary button, table styled by.data-table.No behaviour change; markup and client script are otherwise untouched.