Merge request#14
Open
lohrbini wants to merge 9 commits into
Open
Conversation
lohrbini
commented
Nov 3, 2020
lohrbini
commented
- Updated dependencies
- Removed old 'jade' package
- added simple Dockerfile
- would like to fix hub.docker.com Image
Owner
|
Sorry I never received a notification for this pull request! Just seeing this for the first time now. I'll take a look at this over the next couple of days. Thanks for submitting! |
khaliqgant
reviewed
Oct 7, 2021
| var config = JSON.parse(fs.readFileSync('config.json')); | ||
|
|
||
| debug.log = console.info.bind(console); | ||
| log('TEST'); |
khaliqgant
reviewed
Oct 7, 2021
|
|
||
| <!-- Left Nav Section --> | ||
| <ul class="left"> | ||
| <li class="name-header"><a href="#">Khaliq's Finances</a></li> |
Owner
There was a problem hiding this comment.
I'm not sure what your usage is but I would think it would be nice to remove my name here and have this be dynamic? Not a blocker for merging in your PR but I think would be something nice to have.
khaliqgant
requested changes
Oct 7, 2021
Owner
khaliqgant
left a comment
khaliqgant
left a comment
There was a problem hiding this comment.
This looks good. Couple of changes
- Could you not check in the config.json file as part of this PR? That file would be different from my configuration to your configuration and is encrypted because it could contain sensitive information.
- Remove the console.log debug statement
Thanks again for contributing and very sorry for the long delay!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.