feat(pi): plan-mode interactions and code-review skill#202
Merged
Conversation
Brainstorming output for a code-review capability shipped as a Pi skill (not a mode/extension). Includes the full SKILL.md prompt content informed by Anthropic's current code-review prompt-harness guidance: two-phase find-then-verify, concrete severity criteria, and mandatory file:line citations. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Four tasks: create the SKILL.md, TDD the --skill flag wiring in pi-agent-manager, bundle pi-skills/ in electron-builder, and run a manual smoke test against a planted bug. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
A Pi skill that reviews the current branch's diff against a base ref and writes findings to docs/reviews/YYYY-MM-DD-<topic>.md. Prompt applies Anthropic's current code-review prompt-harness guidance: two-phase find-then-verify, concrete severity criteria (Important / Nit / Pre-existing), and mandatory file:line citations. Wiring follows in a subsequent commit. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Adds getSkillsDir() / getSkillPaths() mirroring the extension-path pattern, and appends --skill flags to the launch command after the -e extension flags. The code-review skill is the first to ship. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Adds pi-skills to extraResources so the bundled code-review skill is present in production DMG/EXE/AppImage outputs, matching the existing pi-extensions bundling pattern. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
# Conflicts: # resources/pi-extensions/fleet-plan-mode.ts # src/renderer/src/components/PiPlanModal.tsx
Owner
Author
Code reviewNo issues found. Checked for bugs and CLAUDE.md compliance. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
resources/pi-skills/code-review/that reviews the current branch's diff against a base ref and writes findings todocs/reviews/YYYY-MM-DD-<topic>.md. Prompt encodes a two-phase find-then-verify protocol with concrete severity criteria and mandatoryfile:linecitations.PiAgentManagergainsgetSkillsDir()/getSkillPaths()mirroring the extension-path pattern, andbuildLaunchCommandappends--skillflags after the existing-eextension flags. Bundled into packaged builds viaelectron-builder.yml.Validation
--skillflag is emitted with POSIX-quoted absolute paths after the-eflags.npm run typecheckclean.--skill <path>flag (verified against livepi --help) accepts a directory and can repeat — matches the wiring shape.nameis 11 chars, lowercase + hyphen, matches parent dir;descriptionis 422 chars (≤1024 limit).Test Plan
/skill:code-review mainin a Pi pane. Expected: report saved underdocs/reviews/, planted bug appears under 🔴 Important with afile:linecitation./skill:code-review mainwhile onmain. Expected: "No blocking issues found." or no file./skill:code-review nonexistent-ref-xyz. Expected: ref-not-found error rather than a bogus review.npm run build+ verifypi-skills/code-review/SKILL.mdis present underResources/in the produced app bundle.🤖 Generated with Claude Code