Merged
Conversation
Update CI workflow to upload both .nupkg and .snupkg files: - Artifact upload now includes both package types using multi-line path - GitHub Packages push uses *.*nupkg pattern to match both extensions Symbol packages (.snupkg) contain debugging information that helps developers debug into the library code. Publishing them to GitHub Packages enables a better debugging experience.
Add MinVer 6.0.0 package for automatic version calculation from Git tags:
- MinVer automatically determines version from Git tags (e.g., v6.1.0)
- Generates proper semantic versions with pre-release identifiers
- Integrates with build height for automatic patch increments
- VersionPrefix (6.1.0) serves as fallback when no tags exist
- MinVerTagPrefix set to 'v' to match conventional tag format
Benefits:
- Eliminates manual version updates in project files
- Automatic versioning in CI/CD pipelines
- Proper pre-release versioning for feature branches
- Consistent with deterministic builds
Microsoft.SourceLink.GitHub is already at latest version 8.0.0.
Version calculation examples:
- On tag v6.1.0: produces version 6.1.0
- After tag: produces version 6.1.1-alpha.0.{height}
- On branch: includes branch name in pre-release identifier
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #267 +/- ##
=======================================
Coverage 86.31% 86.31%
=======================================
Files 29 29
Lines 2053 2053
Branches 247 247
=======================================
Hits 1772 1772
Misses 250 250
Partials 31 31 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Pull request overview
This PR introduces MinVer for automatic versioning based on Git tags. MinVer calculates the package version from Git tags, with VersionPrefix serving as a fallback when no tags exist.
- Adds MinVer package reference with Git tag-based versioning configuration
- Updates CI workflow to include symbol packages (
.snupkg) in artifacts and push operations
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/Scrutor/Scrutor.csproj | Adds MinVer package reference and configuration with tag prefix "v" |
| .github/workflows/build.yml | Updates artifact paths and push patterns to include symbol packages |
Comments suppressed due to low confidence (1)
.github/workflows/build.yml:18
- MinVer requires Git history to calculate versions from tags. The checkout action needs
fetch-depth: 0to fetch the full Git history. Without this, MinVer will only see the shallow clone and may not find version tags, causing it to fall back to the default version.
- name: Checkout
uses: actions/checkout@v4
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
khellang
deleted the
claude/upgrade-to-dotnet-01HBTW8qPH6GH7H2tV8LnYVo
branch
This was referenced Nov 24, 2025
This was referenced Dec 1, 2025
Closed
This was referenced Dec 14, 2025
This was referenced Dec 24, 2025
This was referenced Jan 1, 2026
This was referenced Jan 25, 2026
github-merge-queue bot
pushed a commit
to DFE-Digital/teaching-record-system
that referenced
this pull request
Jan 29, 2026
Updated [Scrutor](https://github.com/khellang/Scrutor) from 6.1.0 to 7.0.0. <details> <summary>Release notes</summary> _Sourced from [Scrutor's releases](https://github.com/khellang/Scrutor/releases)._ ## 7.0.0 ## What's Changed * Add Sponsors section to README by @khellang in khellang/Scrutor#255 * Update to .NET 10 by @khellang in khellang/Scrutor#265 * Add NuGet packaging and GitHub Packages upload to CI by @khellang in khellang/Scrutor#266 * Use MinVer for versioning by @khellang in khellang/Scrutor#267 * Add support for service key registration by @mokarchi in khellang/Scrutor#262 * Add support for exposing decorated services by @adamjones2 in khellang/Scrutor#261 * Add keyed service registration support by @A-Ebrahimzadeh-dev in khellang/Scrutor#260 ## New Contributors * @mokarchi made their first contribution in khellang/Scrutor#262 * @adamjones2 made their first contribution in khellang/Scrutor#261 * @A-Ebrahimzadeh-dev made their first contribution in khellang/Scrutor#260 **Full Changelog**: khellang/Scrutor@v6.1.0...v7.0.0 Commits viewable in [compare view](khellang/Scrutor@v6.1.0...v7.0.0). </details> [](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- <details> <summary>Dependabot commands and options</summary> <br /> You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot show <dependency name> ignore conditions` will show all of the ignore conditions of the specified dependency - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) </details> --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: James Gunn <james@gunn.io>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.