Fix the enums PoolingType and RopeScalingType values and their calls in ModelParameters#105
Merged
kherud merged 1 commit intokherud:masterfrom Jun 20, 2025
Merged
Conversation
Owner
|
Hey @Pierrlf thanks for the PR, looks good to me |
Owner
|
Thanks again for PR, sorry that it took a while, I was to busy with other stuff. I'll release a new version with the changes soon. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Most LLMs expect a string describing the pooling type and rope scaling type parameters, rather than an integer.
Previously, using integers resulted in unrecognized or invalid values.
This pull request corrects the issue by:
- Updating the PoolingType and RopeScalingType enums to use string values instead of integers.
- Adjusting their usage accordingly in the ModelParameters class.