fix(cdc): restore unbiasedByteModulo helper dropped in AES-GCM rewrite#86
Merged
Conversation
decryptLegacyXor still calls it for pre-AES rows, but the helper definition was lost when the registry moved to AES-256-GCM, breaking typecheck on main. Restored verbatim from the legacy encryptor — changing the mapping would break decryption of existing rows.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
Restores the
unbiasedByteModulohelper inapps/cms/src/modules/cdc/registry/encryption.ts, copied verbatim from the legacy XOR encryptor (commit 2b439ba).Why
Main's CI is red:
tscfails withTS2304: Cannot find name 'unbiasedByteModulo'atencryption.ts:137. The AES-256-GCM rewrite keptdecryptLegacyXor(read-only support for pre-AES rows viadecryptCompat) but dropped the helper it calls.Reviewer notes
pnpm -F @lumibase/cms typecheckpasses; all 31 CDC registry tests pass (including legacy round-trip).