Add codespell suggestions for enabke and friends#48
Add codespell suggestions for enabke and friends#48FortiShield wants to merge 2 commits intomasterfrom
Conversation
Reviewer's Guide by SourceryThis pull request updates pre-commit hook versions, refactors assertion messages for readability, modifies a regular expression and f-strings in Updated class diagram for inline ignore regexclassDiagram
class inline_ignore_regex {
-pattern: str
+compile(pattern: str)
}
note for inline_ignore_regex "The regex pattern was modified to allow zero or more spaces after the colon in 'codetypo:ignore'."
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
WalkthroughThe pull request upgrades pre-commit hook repository versions in Changes
Suggested reviewers
Poem
📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (7)
💤 Files with no reviewable changes (2)
⏰ Context from checks skipped due to timeout of 90000ms (7)
🔇 Additional comments (53)
✨ Finishing Touches
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
for more information, see https://pre-commit.ci
CI Feedback 🧐(Feedback updated until commit fab72bc)A test triggered by this PR failed. Here is an AI-generated analysis of the failure:
|
PR Reviewer Guide 🔍Here are some key observations to aid the review process:
|
PR Code Suggestions ✨Explore these optional code suggestions:
|
|||||||||
There was a problem hiding this comment.
Hey @FortiShield - I've reviewed your changes - here's some feedback:
Overall Comments:
- Consider grouping the dictionary changes into a separate commit from the code changes.
- It's great that you're updating the pre-commit hooks to the latest versions.
Here's what I looked at during the review
- 🟡 General issues: 1 issue found
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
| lien->line | ||
| liens->lines |
There was a problem hiding this comment.
issue: Removing "lien" and "liens" seems incorrect.
"lien" is a valid word, although rare. It should probably stay in dictionary_rare.txt.
PR Type
Enhancement, Tests, Bug fix
Description
Improved regex patterns and formatting in
codetypo/_codetypo.py.Enhanced test parameterization and assertions in
codetypo/tests/test_dictionary.py.Updated and expanded typo corrections in
codetypo/data/dictionary.txt.Upgraded dependencies in
.pre-commit-config.yaml.Changes walkthrough 📝
_codetypo.py
Refined regex patterns and string formattingcodetypo/_codetypo.py
dictionary.txt
Expanded typo corrections and mappingscodetypo/data/dictionary.txt
dictionary_rare.txt
Removed rare typo mappingscodetypo/data/dictionary_rare.txt
lienandliens.dictionary_usage.txt
Removed specific usage typo mappingcodetypo/data/dictionary_usage.txt
blueish.test_dictionary.py
Improved test parameterization and assertionscodetypo/tests/test_dictionary.py
.pre-commit-config.yaml
Updated pre-commit dependencies.pre-commit-config.yaml
mdformatto version 0.7.22.ruff-pre-committo version 0.9.10.mypyto version 1.15.0.Summary by CodeRabbit
Chores
Bug Fixes
Refactor / Style
Tests