Repository navigation
feat: purge APT package configuration on uninstall - #32
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Normal APT uninstall now removes package configuration as well as the installed app. This also covers apps installed from local
.debfiles.Changes
Fix the hang when Scope is launched from a terminal: APT inherited terminal stdin in a background process group and stopped with
SIGTTOUwhile restoring terminal modes. Close stdin for captured and streamed commands while preserving Polkit authentication and process-group cleanup.Share purge arguments between simulation, the command preview, and apply. Recognize
Purgactions in protected-package checks and transaction fingerprints, and reject an uninstall simulation that only removes the target.Include package configuration, including obsolete conffiles, in removal estimates. The confirmation explains that personal settings and data remain.
Update README and agent instructions. Include the separately committed request to ignore generated
brag-output/files.Testing
cargo fmt --all -- --checkcargo checkcargo test: 417 passed, 15 ignoredcargo clippy --all-targets --all-features --locked -- -D warningsSIGTTOU; all 24 isolated checks pass with closed stdin.Before: uninstall retained package configuration, the simulation parser did not recognize
Purgrecords, and APT could stop during execution when Scope inherited a launch terminal.After: targeted Rust tests cover purge records, protected indirect purges, changed transaction effects and versions, configuration estimates, the preview command, and completion under terminal job control.
Safety
Door: one-way. Confirmed APT uninstalls now delete package configuration through APT/dpkg.
Blast Radius: APT and shared command execution. Commands receive EOF on stdin; authentication remains with Polkit. Preview, single-use plans, apply-time simulation comparison, protection checks, and rescans remain in place. Autoremove is explicitly disabled. Home-directory data cleanup is outside this change.