fix: version mismatch, missing CSS, dot path bug and clean up dead code#1
Open
Mohammad-Faiz-Cloud-Engineer wants to merge 7 commits into
Open
fix: version mismatch, missing CSS, dot path bug and clean up dead code#1Mohammad-Faiz-Cloud-Engineer wants to merge 7 commits into
Mohammad-Faiz-Cloud-Engineer wants to merge 7 commits into
Conversation
- Vitest unit tests: 70 tests covering template rendering, calculations, visibility toggles, edge cases, and edit-field elements - ESLint 10 + typescript-eslint 8 with flat config for code quality - CI/CD: quality gate (lint → typecheck → test) before Tauri build, applied to both PR checks and release workflows - Remove dead coverage script, fix no-explicit-any lint warning
- quality.test.ts: dead code detection via ts-prune, ESLint zero-errors, TypeScript zero-compile-errors as vitest tests - quality.test.ts: enforce no unused exports on every test run - README: add CI, version, TS, Tauri, Vite, Vitest, ESLint, tests, license, and platform badges
…ove dead CSS - Fix version header showing v1.0.0 while package.json and tauri.conf.json both specify 0.1.0 - Add missing .text-center CSS class referenced 6 times in templates.ts - Fix updateHint() not resolving dot-separated field keys like bankDetails.bankName (FIELD_HINTS only has leaf keys) - Remove 19 dead CSS classes never referenced in any HTML
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I noticed the header was showing v1.0.0 but package.json says 0.1.0, so I fixed that. Also added the .text-center class that was being used in templates but never existed in CSS. There was a bug where updateHint could not find dot separated keys like bankDetails.bankName because FIELD_HINTS only stores leaf keys. Fixed that too.
Cleaned up 19 unused CSS classes. Removed the .vscode folder since it should not be in the repo. Set up a proper CI/CD pipeline with 70 unit tests using Vitest, added ESLint with flat config, quality gates that run lint typecheck and test before build. Also added quality checks for dead exports and zero compile errors. Updated the README with badges and renamed the CI one to build badge. Added push trigger to the workflow so it runs on every push.